morluto
6a6adf703f
Add a read-only app resource session shared by CLI and MCP. Preserve resource-root provenance without inventing executable identity, reject binary-only snapshots and operations, and retain failed cleanup owners across switches and retries. Keep filesystem admission failures typed and preserve cancellation ordering from observed cleanup facts. Document resource routing in the packaged investigation skill. BREAKING CHANGE: resource-only observations may have a null Evidence subject and null executable target digests. Clients must use resource_root and reported per-resource provenance instead. Refs #5589
37 lines
1.2 KiB
TypeScript
37 lines
1.2 KiB
TypeScript
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
|
import { err, type Result } from "../domain/result.js";
|
|
import { AnalysisError } from "../domain/analysisErrorBase.js";
|
|
import type {
|
|
AnalysisClient,
|
|
ExecutionOptions,
|
|
} from "../application/AnalysisProvider.js";
|
|
|
|
/** Close one provider client and normalize unexpected adapter rejection. */
|
|
export const closeAnalysisClient = async (
|
|
client: AnalysisClient,
|
|
providerId: string,
|
|
options: Pick<ExecutionOptions, "progress"> & {
|
|
readonly retainDocument?: boolean;
|
|
readonly onCleanupFailure?: (failure: AnalysisError) => void;
|
|
} = {},
|
|
): Promise<Result<null, AnalysisError>> => {
|
|
try {
|
|
const result = await client.close(options);
|
|
if (!result.ok) options.onCleanupFailure?.(result.error);
|
|
return result;
|
|
} catch (cause: unknown) {
|
|
// A typed cleanup failure already names its leftover resources.
|
|
const failure =
|
|
cause instanceof AnalysisError && cause.cleanupIncomplete
|
|
? cause
|
|
: new ProviderCleanupError(
|
|
providerId,
|
|
["provider-client"],
|
|
{ reason: "provider client close rejected unexpectedly" },
|
|
{ cause },
|
|
);
|
|
options.onCleanupFailure?.(failure);
|
|
return err(failure);
|
|
}
|
|
};
|