From 2b0cff358e319956e72a3262c61686069297e7af Mon Sep 17 00:00:00 2001 From: "93094049+kraemr@users.noreply.github.com" <93094049+kraemr@users.noreply.github.com> Date: Wed, 16 Jul 2025 16:08:49 +0200 Subject: [PATCH 1/2] added optional confirmation to EditValue --- electron/src/control/EditValue.tsx | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/electron/src/control/EditValue.tsx b/electron/src/control/EditValue.tsx index ccbdc93c..d8fc18fb 100644 --- a/electron/src/control/EditValue.tsx +++ b/electron/src/control/EditValue.tsx @@ -38,6 +38,7 @@ type Props = { step?: number; valueSchema?: z.ZodType; inverted?: boolean; + confirmation?: string; renderValue: (value: number) => string; onChange?: (value: number) => void; }; @@ -96,6 +97,7 @@ export function EditValue({ maxLabel, minSlider, maxSlider, + confirmation, onChange, }: Props) { const defaultOrZero = defaultValue ?? 0; @@ -252,10 +254,20 @@ export function EditValue({ const handleSubmit = () => { form.handleSubmit((data) => { - onChange?.(data.value); - setOpen(false); - setNumpadExtended(false); - resetInput(); + if (confirmation) { + if (window.confirm(confirmation)) { + onChange?.(data.value); + setOpen(false); + setNumpadExtended(false); + resetInput(); + } + // else do nothing if user cancels + } else { + onChange?.(data.value); + setOpen(false); + setNumpadExtended(false); + resetInput(); + } })(); }; From 5c00d28396d199444f4bc29bfb414999ce967208 Mon Sep 17 00:00:00 2001 From: "93094049+kraemr@users.noreply.github.com" <93094049+kraemr@users.noreply.github.com> Date: Wed, 16 Jul 2025 16:09:19 +0200 Subject: [PATCH 2/2] raised maximum for Target Pressure --- .../src/machines/extruder/extruder2/Extruder2ControlPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/electron/src/machines/extruder/extruder2/Extruder2ControlPage.tsx b/electron/src/machines/extruder/extruder2/Extruder2ControlPage.tsx index 33e0de2f..0a3afc52 100644 --- a/electron/src/machines/extruder/extruder2/Extruder2ControlPage.tsx +++ b/electron/src/machines/extruder/extruder2/Extruder2ControlPage.tsx @@ -155,7 +155,7 @@ export function Extruder2ControlPage() { unit="bar" title="Target Pressure" min={0.0} - max={150.0} + max={270.0} renderValue={(value) => roundToDecimals(value, 0)} onChange={setInverterTargetPressure} />