From 8f1e0de1f43f366d16d005c69eb8bfddfbe63d74 Mon Sep 17 00:00:00 2001
From: Janik von Rotz <login@janikvonrotz.ch>
Date: Wed, 24 Jan 2024 16:14:58 +0100
Subject: [PATCH] vault backup: 2024-01-24 16:14:58

---
 Odoo Upgrade from 16.0 to 17.0.md | 101 +++++++++++++++++++++++++++++-
 1 file changed, 100 insertions(+), 1 deletion(-)

diff --git a/Odoo Upgrade from 16.0 to 17.0.md b/Odoo Upgrade from 16.0 to 17.0.md
index 0708f6da..db406c3d 100644
--- a/Odoo Upgrade from 16.0 to 17.0.md	
+++ b/Odoo Upgrade from 16.0 to 17.0.md	
@@ -119,4 +119,103 @@ odoo-backup -d $NEW_DATABASE -o tmp/$COMPANY/$NEW_DATABASE.zip
 
 Deploy the upgraded database.
 
-## Troubleshooting
\ No newline at end of file
+## Troubleshooting
+
+### Cannot change data type from numeric to double precision
+
+**Problem**
+
+After the upgrade the restore to the local postgres instance fails with this error message:
+
+```
+2024-01-23 05:05:41 INFO: Restore the dump file 'upgraded.dump' as the database 'erp_17.0'
+2024-01-23 05:06:36 ERROR: Error: The 'pg_restore' command has failed with the following output:
+ pg_restore: while PROCESSING TOC:
+pg_restore: from TOC entry 14650; 2618 472738965 RULE report_project_task_user _RETURN db_1222611
+pg_restore: error: could not execute query: ERROR:  cannot change data type of view column "delay_endings_days" from numeric to double precision
+Command was: CREATE OR REPLACE VIEW public.report_project_task_user AS
+ SELECT ( SELECT 1) AS nbr,
+    t.id,
+    t.id AS task_id,
+    t.active,
+    t.create_date,
+    t.date_assign,
+    t.date_end,
+    t.date_last_stage_update,
+    t.date_deadline,
+    t.project_id,
+    t.priority,
+    t.name,
+    t.company_id,
+    t.partner_id,
+    t.parent_id,
+    t.stage_id,
+    t.state,
+    t.milestone_id,
+        CASE
+            WHEN (pm.id IS NOT NULL) THEN true
+            ELSE false
+        END AS has_late_and_unreached_milestone,
+    t.description,
+    NULLIF(t.rating_last_value, (0)::double precision) AS rating_last_value,
+    avg(rt.rating) AS rating_avg,
+    t.working_days_close,
+    t.working_days_open,
+    t.working_hours_open,
+    t.working_hours_close,
+    (EXTRACT(epoch FROM (t.date_deadline - (now() AT TIME ZONE 'UTC'::text))) / ((3600 * 24))::numeric) AS delay_endings_days,
+    count(td.task_id) AS dependent_ids_count,
+        CASE
+            WHEN (COALESCE(t.allocated_hours, (0)::double precision) = (0)::double precision) THEN (0.0)::double precision
+            ELSE LEAST(((t.effective_hours * (100)::double precision) / t.allocated_hours), (100)::double precision)
+        END AS progress,
+    t.effective_hours,
+    ((t.allocated_hours - t.effective_hours) - t.subtask_effective_hours) AS remaining_hours,
+        CASE
+            WHEN (t.allocated_hours > (0)::double precision) THEN (t.remaining_hours / t.allocated_hours)
+            ELSE (0)::double precision
+        END AS remaining_hours_percentage,
+    t.allocated_hours,
+    t.overtime,
+    t.total_hours_spent,
+    t.planned_date_begin,
+    t.sale_line_id,
+    t.sale_order_id,
+    sol.remaining_hours AS remaining_hours_so
+   FROM ((((public.project_task t
+     LEFT JOIN public.rating_rating rt ON (((rt.res_id = t.id) AND ((rt.res_model)::text = 'project.task'::text) AND (rt.consumed = true) AND (rt.rating >= (1)::double precision))))
+     LEFT JOIN public.project_milestone pm ON (((pm.id = t.milestone_id) AND (pm.is_reached = false) AND (pm.deadline <= (now())::date))))
+     LEFT JOIN public.task_dependencies_rel td ON ((td.depends_on_id = t.id)))
+     LEFT JOIN public.sale_order_line sol ON ((t.id = sol.task_id)))
+  WHERE (t.project_id IS NOT NULL)
+  GROUP BY t.id, t.active, t.create_date, t.date_assign, t.date_end, t.date_last_stage_update, t.date_deadline, t.project_id, t.priority, t.name, t.company_id, t.partner_id, t.parent_id, t.stage_id, t.state, t.rating_last_value, t.working_days_close, t.working_days_open, t.working_hours_open, t.working_hours_close, t.milestone_id, pm.id, td.depends_on_id, t.effective_hours, t.subtask_effective_hours, t.allocated_hours, t.overtime, t.total_hours_spent, t.planned_date_begin, t.sale_line_id, t.sale_order_id, sol.remaining_hours;
+
+
+pg_restore: warning: errors ignored on restore: 2
+```
+
+**Cause**
+
+This error is mostly likely connect with the wrong psql version.
+
+This versions have been confirmed to work:
+
+```
+➜  Odoo-Build git:(16.0) ✗ pg_restore -V
+pg_restore (PostgreSQL) 13.6 (Ubuntu 13.6-0ubuntu0.21.10.1)
+➜  Odoo-Build git:(16.0) ✗ pg_dump -V
+pg_dump (PostgreSQL) 13.6 (Ubuntu 13.6-0ubuntu0.21.10.1)
+```
+
+And these versions did not:
+
+```bash
+laszlokr@mintsystem:~/work/mintsystem/Odoo-Build$ pg_restore -V
+pg_restore (PostgreSQL) 14.10 (Ubuntu 14.10-0ubuntu0.22.04.1)
+laszlokr@mintsystem:~/work/mintsystem/Odoo-Build$ pg_dump -V
+pg_dump (PostgreSQL) 14.10 (Ubuntu 14.10-0ubuntu0.22.04.1)
+```
+
+**Solution**
+
+If required downgrade the psql tools.