From b6e293d93734e00501be573aa34deb2cb0d54829 Mon Sep 17 00:00:00 2001
From: Janik von Rotz <login@janikvonrotz.ch>
Date: Mon, 4 May 2026 08:51:55 +0200
Subject: [PATCH] feat(snippets): remove obsolete snippets and enhance task
 script with validation checks

---
 .../mint_system.hr_attendance.add_note_field.xml  |  5 -----
 ...8.external_layout_din5008.style_swift-link.xml | 11 -----------
 ..._layout_din5008_saleorder.style_swift-link.xml | 11 -----------
 task                                              | 15 +++++++++++++--
 4 files changed, 13 insertions(+), 29 deletions(-)
 delete mode 100644 snippets/mint_system.hr_attendance.add_note_field.xml
 delete mode 100644 snippets/mint_system.l10n_din5008.external_layout_din5008.style_swift-link.xml
 delete mode 100644 snippets/mint_system.l10n_din5008_sale.external_layout_din5008_saleorder.style_swift-link.xml

diff --git a/snippets/mint_system.hr_attendance.add_note_field.xml b/snippets/mint_system.hr_attendance.add_note_field.xml
deleted file mode 100644
index d1248f48..00000000
--- a/snippets/mint_system.hr_attendance.add_note_field.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<data priority="50">
-    <xpath expr="//field[@name='overtime_hours']" position="after">
-        <field name="x_anwesenheit_notiz"/>
-    </xpath>
-</data>
\ No newline at end of file
diff --git a/snippets/mint_system.l10n_din5008.external_layout_din5008.style_swift-link.xml b/snippets/mint_system.l10n_din5008.external_layout_din5008.style_swift-link.xml
deleted file mode 100644
index 5d00ba63..00000000
--- a/snippets/mint_system.l10n_din5008.external_layout_din5008.style_swift-link.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<data priority="60">
-
-    <xpath expr="//div[@class='address']" position="attributes">
-        <attribute name="style">font-size: 13px;</attribute>
-    </xpath>
-
-    <xpath expr="//div[@class='colored_address']" position="attributes">
-        <attribute name="style">font-size: 10px;</attribute>
-    </xpath>
-
-</data>
\ No newline at end of file
diff --git a/snippets/mint_system.l10n_din5008_sale.external_layout_din5008_saleorder.style_swift-link.xml b/snippets/mint_system.l10n_din5008_sale.external_layout_din5008_saleorder.style_swift-link.xml
deleted file mode 100644
index a6a70590..00000000
--- a/snippets/mint_system.l10n_din5008_sale.external_layout_din5008_saleorder.style_swift-link.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<data priority="60">
-
-    <xpath expr="//t[@t-set='din5008_address_block']/tr" position="attributes">
-        <attribute name="style">font-size: 16px;</attribute>
-    </xpath>
-    
-    <xpath expr="//address[@t-esc='doc.partner_shipping_id']" position="attributes">
-        <attribute name="t-options">{"widget": "contact", "fields": ["address", "name"], "no_marker": True}</attribute>/&gt;
-    </xpath>
-    
-</data>
\ No newline at end of file
diff --git a/task b/task
index e5ee33db..f7faa286 100755
--- a/task
+++ b/task
@@ -1591,9 +1591,14 @@ EOF
         echo -e "\033[38;5;214mTEST\033[0m: Check translations auto update"
         sed -i 's/Nachname/Familienname/g' oca/partner-contact/partner_firstname/i18n/de.po
         restart odoo
-        # FIXME: Check if translations updated
+        sleep 3
+        # FIXME: Check if translation is updated
         # docker logs odoo 2>&1 | grep "Updating translations for all active languages and installed modules."
-
+        field_description=$(task shell test "print(env.ref('partner_firstname.field_res_partner__lastname').field_description)")
+        if [[ "$user_count" != "Familienname" ]]; then
+            log-error "Expected 'Familienname' field description, but got $field_description"
+            exit 1
+        fi
         # FIXME: These tests do not work in GitHub Runner env.
 
         # echo -e "\033[38;5;214mTEST\033[0m: Prepare container for testing."
@@ -1623,6 +1628,12 @@ EOF
         sed -i "/\"version\":/c\    \"version\": \"${ODOO_VERSION}.9.0.0\"," oca/partner-contact/partner_firstname/__manifest__.py
         echo "Execute the module upgrade."
         exec odoo update-module partner_firstname
+        partner_count=$(task shell test "print(env['res.partner'].search_count([('name','=','Mitchell Adminx')]))")
+        if [[ "$user_count" != "1" ]]; then
+            log-error "Expected 1 partner, but got $partner_count"
+            exit 1
+        fi
+
         # FIXME: Check if module is migrated
         # docker logs odoo 2>&1 | grep "module partner_firstname: Running migration"